lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Apr 2009 12:41:01 +0200 From: Patrick McHardy <kaber@...sh.net> To: David Miller <davem@...emloft.net> CC: dada1@...mosbay.com, jpirko@...hat.com, lizf@...fujitsu.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, jgarzik@...ox.com, shemminger@...ux-foundation.org, bridge@...ts.linux-foundation.org, fubar@...ibm.com, bonding-devel@...ts.sourceforge.net, mschmidt@...hat.com, ivecera@...hat.com Subject: Re: [PATCH 1/3] net: introduce a list of device addresses dev_addr_list David Miller wrote: > From: Patrick McHardy <kaber@...sh.net> > Date: Wed, 15 Apr 2009 12:13:57 +0200 > >> David Miller wrote: >>> From: Eric Dumazet <dada1@...mosbay.com> >>> Date: Wed, 15 Apr 2009 11:27:50 +0200 >>> >>>> Since you obviously need a write lock here to be sure following >>>> can be done by one cpu only. >>>> >>>> You have same problem all over this patch. >>> RTNL semaphore is held across all modification operations. >> If this will also be used for multicast lists, changes can happen >> (IPv6) without the RTNL. > > Indeed, that is true :-/ Herbert (I think) suggested to make address list updates in softirq context a two-step process, where addresses would first be added to a temporary list and the final change would be done in process context while holding the RTNL. Given the complicated mess we currently have, this would be a very worthwhile change IMO. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists