netdev - Re: [PATCH] net: Fix GRO for multiple page fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Apr 2009 15:03:30 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: Fix GRO for multiple page fragments

On Fri, 2009-04-17 at 17:14 +0800, Herbert Xu wrote:
> On Fri, Apr 17, 2009 at 01:27:59AM -0700, David Miller wrote:
> >
> > I think the code still isn't right after your changes.
> > 
> > The intent seems to be to append frags from 'info' into the SKB,
> > so that it works even if the SKB already has some frags.
> > 
> > And being that cxgb3 is pretty well tested with GRO I'm suspicious
> > even moreso :-)
> > 
> > Herbert?
> 
> Ah, I'd replied via private email to Ben.  This whole loop no
> longer exists in net-next.  As for 2.6.30, the existing loop
> should be correct.

The loop is iterating forward, not backward, so why initialise frag to
point to the last fragment?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html