netdev - Re: [PATCH] Allow fragmentation of VLAN packets traversing a bridge.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Apr 2009 19:20:40 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Saikiran Madugula <hummerbliss@...il.com>
CC:	netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] Allow fragmentation of VLAN packets traversing a bridge.

Saikiran Madugula wrote:
> Patrick McHardy wrote:
>>> -    if (skb->protocol == htons(ETH_P_IP) &&
>>> +    if ((skb->protocol == htons(ETH_P_IP) || IS_VLAN_IP(skb)) &&
>>>          skb->len > skb->dev->mtu &&
>>>          !skb_is_gso(skb))
>>>          return ip_fragment(skb, br_dev_queue_push_xmit);
>> Please add an additional check for skb->nfct != NULL to make sure
>> that this only refragments packets defragmented by conntrack.
> 
> Thanks for the feedback, skb->nfct is present only if CONFIG_NF_CONNTRACK or
> CONFIG_NF_CONNTRACK_MODULE is defined. Was wondering if the entire check before
> ip_fragment is necessary if NF_CONNTRACK is not defined. If not, I will post
> updated patch as per your suggestion.

Good point. Yes, everything related to fragmenting is only needed
with NF_CONNTRACK, so an additional ifdef makes sense.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html