netdev - Re: gro: Fix use after free in tcp_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 Apr 2009 02:34:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org, mwagner@...hat.com
Subject: Re: gro: Fix use after free in tcp_gro_receive

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 17 Apr 2009 17:25:53 +0800

> gro: Fix use after free in tcp_gro_receive
> 
> After calling skb_gro_receive skb->len can no longer be relied
> on since if the skb was merged using frags, then its pages will
> have been removed and the length reduced.
> 
> This caused tcp_gro_receive to prematurely end merging which
> resulted in suboptimal performance with ixgbe.
> 
> The fix is to store skb->len on the stack.
> 
> Reported-by: Mark Wagner <mwagner@...hat.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html