netdev - Re: vlan/macvlan: fix NULL pointer dereferences in ethtool handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 Apr 2009 16:49:28 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: vlan/macvlan: fix NULL pointer dereferences in ethtool handlers

David Miller wrote:
> From: Patrick McHardy <kaber@...sh.net>
> Date: Fri, 17 Apr 2009 18:05:32 +0200
> 
>>     vlan/macvlan: fix NULL pointer dereferences in ethtool handlers
>>     
>>     Check whether the underlying device provides a set of ethtool ops before
>>     checking for individual handlers to avoid NULL pointer dereferences.
>>     
>>     Reported-by: Art van Breemen <ard@...egraafnet.nl>
>>     Signed-off-by: Patrick McHardy <kaber@...sh.net>
> 
> Applied, thanks Patrick.
> 
> These things beg for helper functions in my opinion.

Something like this?



View attachment "x" of type "text/plain" (4616 bytes)