netdev - Re: [PATCH 2.6.30 2/4] cxgb3: fix workqueue flush issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 20 Apr 2009 02:08:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	divy@...lsio.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	swise@...ngridcomputing.com
Subject: Re: [PATCH 2.6.30 2/4] cxgb3: fix workqueue flush issues

From: Divy Le Ray <divy@...lsio.com>
Date: Fri, 17 Apr 2009 15:21:17 -0700

> The fatal error task can be scheduled while processing an offload packet
> in NAPI context when the connection handle is bogus. this can race
> with the ports being brought down and the cxgb3 workqueue being flushed.
> Stop napi processing before flushing the work queue.
> 
> The ULP drivers (iSCSI, iWARP) might also schedule a task on keventd_wk 
> while releasing a connection handle (cxgb3_offload.c::cxgb3_queue_tid_release()).
> The driver however does not flush any work on keventd_wq while being unloaded. 
> This patch also fixes this.
> 
> Also call cancel_delayed_work_sync in place of the the deprecated
> cancel_rearming_delayed_workqueue.
> 
> Signed-off-by: Divy Le Ray <divy@...lsio.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html