| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Apr 2009 01:41:58 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mcarlson@...adcom.com Cc: netdev@...r.kernel.org, mchan@...adcom.com, benli@...adcom.com, andy@...yhouse.net Subject: Re: [PATCH 2/8] tg3: Allow screaming interrupt detection From: "Matt Carlson" <mcarlson@...adcom.com> Date: Mon, 20 Apr 2009 09:55:01 -0700 > The tg3 driver's ISR is coded to accept interrupts as its own if the > status block tag does not equal the last tag the driver has seen. The > last_tag field is updated from tg3_poll. In a screaming interrupt > situation from another device sharing tg3's IRQ, tg3_poll does not get > a chance to be called, so the last_tag will always be out of sync with > the status block tag. Consequently, the driver will continually > declare the screaming interrupts as its own, thus thwarting the > screaming interrupt detection logic. > > This patch solves the problem by creating a new last_irq_tag member and > recording the status block tag in the ISR. The ISR then checks the > last_irq_tag for interrupt ownership. > > Many thanks to John Marvin for the detailed bug report and analysis and > Michael Chan for the bugfix. > > Signed-off-by: Matt Carlson <mcarlson@...adcom.com> > Signed-off-by: Michael Chan <mchan@...adcom.com> > Tested-by: John Marvin <jsm@...hp.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists