netdev - Re: [PATCH] Add new cs89x0 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Apr 2009 00:53:28 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	netdev@...r.kernel.org, Lennert Buytenhek <kernel@...tstofly.org>,
	Ivo Clarysse <ivo.clarysse@...il.com>,
	Gilles Chanteperdrix <gilles.chanteperdrix@...omai.org>
Subject: Re: [PATCH] Add new cs89x0 driver

On Wed, Apr 22, 2009 at 09:59:30AM +0200, Sascha Hauer wrote:

> While this is a very old chip it is still in use on some embedded
> boards.  I see myself unable to fix the in Kernel driver to bring
> it to driver model support, so this patch adds a new driver designed
> to replace the old one, at least for non-ISA hardware.

I had the same thought initially when I started working on mv643xx_eth,
but I decided to try and beat the existing driver into shape anyway.  The
mv643xx_eth driver now is not too different from how I would have written
it had I rewritten it from scratch, and refactoring it took about a
hundred commits and probably a bunch more effort than just rewriting it
would have taken, but in the end I probably _saved_ myself time by being
able to (have users) bisect problems instead of having to spend time
trying to figure out why driver A works but B doesn't or vice versa, not
having to chase people to switch their platforms over to the new driver,
etc.

(I'm not saying that there's absolutely no other way for you to go than
to do the same thing -- it's just a thought.)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html