netdev - Re: [PATCH 1/2] Add an alternative cs89x0 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Apr 2009 14:18:21 +0200
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Ivo Clarysse <ivo.clarysse@...il.com>
Cc:	netdev@...r.kernel.org, Lennert Buytenhek <kernel@...tstofly.org>,
	Gilles Chanteperdrix <gilles.chanteperdrix@...omai.org>
Subject: Re: [PATCH 1/2] Add an alternative cs89x0 driver

On Wed, Apr 22, 2009 at 11:28:17AM +0200, Ivo Clarysse wrote:
> On Wed, Apr 22, 2009 at 9:59 AM, Sascha Hauer <s.hauer@...gutronix.de> wrote:
> 
> > +#define CS8900A                        0x0000
> > +#define REV_B                  7
> > +#define REV_C                  8
> > +#define REV_D                  9
> 
> These REV_B / REV_C / REV_D defines are not used, and in fact depend
> on the cs89x0x variant.
> 
> > +       dev_info(&pdev->dev, "CS8900A rev %c detected\n",
> > +                       'B' + REVISION(value) - REV_B);
> 
> This will report incorrectly for CS8900 (not CS8900A),  and for CS8900A rev. F:

Ok, will fix.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html