netdev - RE: [PATCH] net: Add the FCoE Initialization Protocol ethertype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 May 2009 15:53:32 -0700
From:	"Love, Robert W" <robert.w.love@...el.com>
To:	David Miller <davem@...emloft.net>,
	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: Add the FCoE Initialization Protocol ethertype

David Miller wrote:
> From: Robert Love <robert.w.love@...el.com>
> Date: Fri, 01 May 2009 11:55:32 -0700
> 
>> FIP is the FCoE Initialization Protocol and this patch
>> adds the protocol ethertype to the kernel's list of ethertypes.
>> 
>> Signed-off-by: Joe Eykholt <jeykholt@...co.com>
>> Signed-off-by: Robert Love <robert.w.love@...el.com>
> 
> You can add this value, when you add the protocol implementation
> into the upstream sources.

The FIP implementation is upstream, in drivers/scsi/libfcoe.c.
There is a local define in include/scsi/fc/fc_fip.h for ETH_P_FCOE
and I'd rather move it to the propper location.

include/scsi/fc/fc_fip.h:28:#ifndef ETH_P_FIP
include/scsi/fc/fc_fip.h:29:#define ETH_P_FIP	0x8914 /* FIP Ethertype */

One thing to note is that I will later push a patch to linux-scsi
to remove the define in fc_fip.h. It may be preferable to do both
operations in one patch, but I was worried about cross-subsystem
conflicts with other patches to either netdev or fcoe code. I can
refresh this patch to include the fc_fip.h removal and you and James
can decide who takes the patch if that's a better aproach.--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html