netdev - Re: [PATCH 02/12] fs_enet: Add MPC5121 FEC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 May 2009 16:29:59 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Wolfgang Denk <wd@...x.de>
Cc:	linuxppc-dev@...abs.org, John Rigby <jrigby@...escale.com>,
	Piotr Ziecik <kosmo@...ihalf.com>, netdev@...r.kernel.org,
	John Rigby <jcrigby@...il.com>, Detlev Zundel <dzu@...x.de>
Subject: Re: [PATCH 02/12] fs_enet: Add MPC5121 FEC support.

On Wed, May 6, 2009 at 4:01 PM, Wolfgang Denk <wd@...x.de> wrote:
> Dear Grant,
>
> in message <fa686aa40905061333q29c263c8p24856c048e30f4d0@...l.gmail.com> you wrote:
>>
> ...
>> > #ifdef CONFIG_FS_ENET_HAS_FEC
>> > +#ifdef CONFIG_FS_ENET_MPC5121_FEC
>> > +    {
>> > +        .compatible = "fsl,mpc5121-fec",
>> > +        .data = (void *)&fs_fec_ops,
>> > +    },
>> > +#else
>> >    {
>> >        .compatible = "fsl,pq1-fec-enet",
>> >        .data = (void *)&fs_fec_ops,
>> >    },
>> > #endif
>> > +#endif
>>
>> Hmmm.  A lot of these #ifdefs in here.  Does this have a multiplatform
>> impact?  Not to mention the fact that it's just plain ugly.  :-)
>
> Agreed that it's ugly, but duplicatio9ng the code would have been even
> worse. I don't think that it has multiplatform - at least not as long
> as you don't ask for one image that runs on 83xx and on 512x.

Actually, I *am* asking for one image that runs on 83xx, 52xx and
521x.  I already can and do build and test a single image which boots
on all my 52xx boards, on my 8349 board, and on my G4 Mac.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html