lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 May 2009 01:30:57 +0200 From: Florian Westphal <fw@...len.de> To: Jiri Pirko <jpirko@...hat.com> Cc: Florian Westphal <fw@...len.de>, bonding-devel@...ts.sourceforge.net, netdev@...r.kernel.org Subject: Re: [PATCH] bonding: fix panic if initialization fails Jiri Pirko <jpirko@...hat.com> wrote: > > err: > >- list_for_each_entry(bond, &bond_dev_list, bond_list) { > >- bond_work_cancel_all(bond); > >- destroy_workqueue(bond->wq); > >- } > This looks correct. > > >- > >- bond_destroy_sysfs(); > Why this is not here anymore? I think it should be called in this function. Thanks for reviewing. I removed it because, if you hit this error path, sysfs registration failed, so there is no entry to remove. Its not a bug to call it though (sysfs_hash_and_remove() returns -ENOENT in that case), and i can re-spin without that change if you want. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists