lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 May 2009 18:05:39 +0300 From: Avi Kivity <avi@...hat.com> To: Rusty Russell <rusty@...tcorp.com.au> CC: Mark McLoughlin <markmc@...hat.com>, dlaor@...hat.com, netdev@...r.kernel.org, Dor Laor <dor@...hat.com>, virtualization@...ts.linux-foundation.org Subject: Re: [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Rusty Russell wrote: > On Sun, 17 May 2009 03:57:01 pm Avi Kivity wrote: > >> Rusty Russell wrote: >> >>> +static void adjust_threshold(struct vring_virtqueue *vq, >>> + unsigned int out, unsigned int in) >>> +{ >>> + /* There are really two species of virtqueue, and it matters here. >>> + * If there are no output parts, it's a "normally full" receive queue, >>> + * otherwise it's a "normally empty" send queue. */ >>> >> This comment is true for networking, but not for block. ++overkill with >> a ->adjust_threshold op. >> > > No, it's true for block. It has output parts, so we should reduce threshold > when it's full. Network recvq is an example which should reduce threshold > when it's empty. > You mean the header that contains the sector number? It's a little incidental, but I guess it works. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists