netdev - Re: [PATCH 1/2] myri10ge: allow LRO to be enabled via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 May 2009 15:26:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	brice@...i.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] myri10ge: allow LRO to be enabled via ethtool

From: Brice Goglin <brice@...i.com>
Date: Tue, 19 May 2009 22:15:32 +0200

> Allow myri10ge LRO to be enabled/disabled via ethtool
> (and by the stack for packet forwarding).
> 
> Signed-off-by: Brice Goglin <brice@...i.com>

So I applied these two patches for now to net-next-2.6
but in the long term I think it's probably better to convert
this driver to GRO as we're trying to get rid of LRO and
GRO handles forwarding and all of that stuff transparently.

And I also still want the myri10ge_lro module option removed
regardless of whether you do a GRO conversion or not.

If LRO/GRO causes a performance regression in some situation,
we should fix it instead of papering over this junk with
module options.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html