lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 23 May 2009 18:51:26 +0200 From: Wolfgang Grandegger <wg@...ndegger.com> To: Arnd Bergmann <arnd@...db.de> CC: devicetree-discuss@...abs.org, Linux Netdev List <netdev@...r.kernel.org>, linuxppc-dev <Linuxppc-dev@...abs.org> Subject: Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver Arnd Bergmann wrote: > On Friday 22 May 2009, Wolfgang Grandegger wrote: >> This patch adds a generic driver for SJA1000 chips on the OpenFirmware >> platform bus found on embedded PowerPC systems. > > Nice driver! > >> +static u8 sja1000_ofp_read_reg(const struct net_device *dev, int reg) >> +{ >> + return in_8((void __iomem *)(dev->base_addr + reg)); >> +} >> + >> +static void sja1000_ofp_write_reg(const struct net_device *dev, int reg, u8 val) >> +{ >> + out_8((void __iomem *)(dev->base_addr + reg), val); >> +} > > Minor nitpicking: dev->base_addr should be defined as an __iomem pointer > so you can avoid the cast here and in the ioremap/iounmap path. Here the member "base_addr" of "struct net_device" is used and it's not up to me to change the type. Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists