netdev - Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 May 2009 12:53:05 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	David Brownell <david-b@...bell.net>
Cc:	Baruch Siach <baruch@...s.co.il>,
	Michael Hennerich <michael.hennerich@...log.com>,
	netdev@...r.kernel.org, Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER_FALLING for IRQ by default

On Tuesday 26 May 2009 07:24:17 David Brownell wrote:
> On Tuesday 26 May 2009, Baruch Siach wrote:
> > On Tue, May 26, 2009 at 06:16:47AM -0400, Mike Frysinger wrote:
> > > From: Michael Hennerich <michael.hennerich@...log.com>
> > >
> > > Rather than have the default IRQ flags not be usable, use the logical
> > > settings which match the hardware.  Since the part is /INT, it makes
> > > sense to have it default to a falling trigger.  If a board truly needs
> > > something different, it still can tweak the defaults in its own board
> > > file.
> >
> > You revert David Brownell's commit here
> > (c7b7b042068cd12b8b155722d24686f70b88ced1). Added to CC.
>
> Right ... the appended patch will *undo* the setting
> established in the board init code via set_irq_type().
>
> Moreover, it completely prevents working on systems which
> only support "both edges" triggering.

how can it provide breakage when people are forced to use set_irq_type() ?

> So I'd NAK this, on the grounds that it causes severe
> breakage.

i see no consumers of this driver at all in mainline, so i dont think it 
causes any in tree breakage at all
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html