netdev - Re: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2009 06:49:42 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, michael.hennerich@...log.com,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC 
	interrupt may not be shared

On Fri, May 29, 2009 at 05:01, David Miller wrote:
> From: Mike Frysinger <vapier@...too.org>
>> From: Michael Hennerich <michael.hennerich@...log.com>
>>
>> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
>> Signed-off-by: Mike Frysinger <vapier@...too.org>
>> Signed-off-by: Bryan Wu <cooloney@...nel.org>
>
> I'm not applying this.
>
> Either take the time to make this interrupt handler cope with shared
> interrupts (the most preferred) or take the time to write an
> excruciatingly long winded and explicit commit log message explaining
> why that's not possible.
>
> And I want the commit log message path to be as painful as possible so
> that you choose to fix this driver's IRQ handler to behave sanely
> instead. :-)

the hardware has a dedicated internal IRQ line for the Blackfin MAC.
it makes no sense to mark it as shared.  there is nothing it could
possibly be shared with.
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html