netdev - Re: [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2009 07:42:15 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, uclinux-dist-devel@...ckfin.uclinux.org,
	sonic.zhang@...log.com, cooloney@...nel.org
Subject: Re: [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet 
	transmission when polling with KGDB

On Fri, May 29, 2009 at 07:27, David Miller wrote:
> From: Mike Frysinger <vapier.adi@...il.com>
>> that isnt how the DMA is being used here.  there is no register to
>> read back because the DMA controller is doing the reading indirectly.
>> but along those lines, it's not entirely clear which DMA registers
>> this SSYNC is supposed to be protecting because all of the updates are
>> happening on the descriptors in external memory, not the DMA registers
>> themselves.  i'll have Sonic clarify.
>
> Yes, that's really confusing because the commit message says
> "registers".

the SSYNC() is still correct, but the comment is wrong/misleading as
it isnt protecting the DMA registers, it's flushing the internal write
buffers
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html