netdev - Re: [PATCH net-next 2/2] cpmac: prevent fatal exception in cpmac_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Jun 2009 02:58:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] cpmac: prevent fatal exception in
 cpmac_end_xmit

From: Florian Fainelli <florian@...nwrt.org>
Date: Sun, 31 May 2009 22:59:15 +0200

> From: Stefan Weil <weil@...l.berlios.de>
> 
> We should not be stopping the subqueues in cpmac_end_xmit
> but rather test the status of them. Replace the calls to
> netif_subqueue_stop by __netif_subqueue_stopped. This
> fixes an unrecoverable exception from happening when
> running the driver.
> 
> Signed-off-by: Stefan Weil <weil@...l.berlios.de>
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>

Applied, but this commit message was completely wrong and
therefore misleading to anyone trying to track down why this
change was made.

The problem is that netif_subqueue_stopped() takes a SKB
pointer, whereas we're passing in an integer queue index
here.

Therefore, merely providing the obvious compile warning that
was produced by this incorrect argument type would have
explained everything, and accurately.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html