netdev - Re: [PATCH] forcedeth: Addition of new device id (resend without pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Jun 2009 12:24:37 -0400
From:	Ayaz Abdulla <aabdulla@...dia.com>
To:	David Miller <davem@...emloft.net>
CC:	"manfred@...orfullife.com" <manfred@...orfullife.com>,
	"akpm@...l.org" <akpm@...l.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] forcedeth: Addition of new device id (resend without
 pci_ids.h)



David Miller wrote:
> From: Ayaz Abdulla <aabdulla@...dia.com>
> Date: Wed, 03 Jun 2009 12:06:04 -0400
> 
> 
>>Add support for new ethernet device in the MCP89 chipset.
>>
>>Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>
> 
> 
> Just use the constant directly, please :-)

But there is place in the patch that refers to device id so it makes 
more sense to have a macro. i.e

+       if (np->device_id != PCI_DEVICE_ID_NVIDIA_NVENET_40)

other places in the code also refer to device ids for certain 
workarounds. i.e.

		if ((id->device == PCI_DEVICE_ID_NVIDIA_NVENET_12 ||
		     id->device == PCI_DEVICE_ID_NVIDIA_NVENET_13) &&



> 
> The new macro is completely superfluous.
> 
> Trust me, other drivers just use the PCI ID constant directly in their
> tables too, and no animals were harmed by the experiment :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html