lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Jun 2009 15:08:29 +0200 From: Martin Fuzzey <mfuzzey@...il.com> To: nico@....org Cc: netdev@...r.kernel.org Subject: SMC91x: forcing speed Hi, I am using the SMC91x driver on a based ARM board that has a hardware problem causing 100Mbps mode not to work (even though the PHY negotiates to that speed). Unfortunately fixing the hardware is not an option :( I'm currently using this simple hack to make it work: diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c index fdcbaf8..95f129e 100644 --- a/drivers/net/smc91x.c +++ b/drivers/net/smc91x.c @@ -2022,7 +2022,9 @@ static int __devinit smc_probe(struct net_device *dev, void __iomem *ioaddr, if (lp->version >= (CHIP_91100 << 4)) { lp->ctl_rfduplx = 1; +#ifndef CONFIG_MACH_PKN_TGX200 lp->ctl_rspeed = 100; +#endif } /* Grab the IRQ */ Is there a better way of doing this that would be acceptable for mainline? The options I can think of are : 1) platform data : (new bit in flags or new member in struct smc91x_platdata) 2) command line parameter I prefer 1) since that lets the board specific code do it rather than messing with bootloader parameters. I need NFS root so setting the speed later with miitool etc is not an option [I don't want to add an initrd just for this] I'm happy to submit the patch if we can agree on the method and other people may be interested or should I just stick to my current hack? Regards, Martin -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists