netdev - Re: virtio_net: Set correct gso->hdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Jun 2009 14:27:09 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: virtio_net: Set correct gso->hdr_len

On Fri, Jun 05, 2009 at 01:51:05PM +0930, Rusty Russell wrote:
>
> But are we allowed to make the assumption that skb_headlen() == 
> skb_transport_header(skb) + sizeof(transport header) ?  Or should we be 
> checking that here?

We don't care.  We just want to preserve whatever the OS gave us.
If it's bogus, the backend will reject it or fix it up.

> Also how did this ever work?  Why are we getting packets through at all?

Because the backend fixed it up.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html