netdev - Re: [RFC PATCH] Ethtool style in kernel network driver configuration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Jun 2009 23:39:29 +0200
From:	Martin Fuzzey <mfuzzey@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	Nicolas Pitre <nico@....org>, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] Ethtool style in kernel network driver configuration.

Ben Hutchings wrote:
> It's not my call as to whether your needs are accommodated, and in any
> case I'm not trying to dismiss them.  I'm trying to understand them and
> to suggest what seems like a better solution.
>   
Unfortunately the solution you are proposing (modifying the drivers) has
already been rejected.

The solution here, proposed by Nicolas and implemented by myself, has
already been accepted in principle by David Miller (subject to a clean
implementation and being maintained).

The only argument for your (much more intrusive) solution is that it
will prevent someone later shooting themselves in the foot by using
ethtool to reconfigure the interface to a non working state. But :

1) With the proposed solution there's no need to even have the ethool
binary available.
2) If you're that worried about people shooting themselves in the foot
let's modify the filesystems to refuse deleting files in /bin...

> I'm primarily a driver maintainer and I work with an out-of-tree module
> as well as an in-tree driver.  I've had to deal with many objections in
> the process of submitting that out-of-tree code, and I worked to
> overcome them.  This took several iterations and it was quite
> frustrating at times.  But the result was a better driver.
>   
Yes but it sounds like you're describing the normal review process not
an unwillingless to accept the very idea of your driver.
I have no problem undergoing several iterations (hey that's why I called
it RFC) but I had been hoping for constructive criticism of the
implementation not the principle or the need for this type of module
[which I thought settled in the original thread].

I consider it one of the great strengths of linux that  it can run on
everything from cell phones to super computers and meet the diverse
needs of all those people. I personally have no use for the majority of
the kernel code but I don't see that as as reason it shouldn't be there.

If your view prevails all I will have achieved is the replacement of my
personel 2 line #ifdef hack by 500 lines of "generic" code that no one
else will ever see. Of course in the grand scheme of things that's
insignificant but then I hope people don't complain about embedded
developpers not contributing enough. I did try, really.

Unless anyone wants to discuss the implementation this is my last post
on this subject.

Martin

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html