netdev - Re: 3rd attempt to initialize MAC address on r8169

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 19 Jun 2009 13:30:32 +0200
From:	Mikael Pettersson <mikpe@...uu.se>
To:	Ivan Vecera <ivecera@...hat.com>
Cc:	Francois Romieu <romieu@...zoreil.com>,
	Mikael Pettersson <mikpe@...uu.se>,
	Tim Durack <tdurack@...il.com>, netdev@...r.kernel.org
Subject: Re: 3rd attempt to initialize MAC address on r8169

Ivan Vecera writes:
 > Francois Romieu napsal(a):
 > > Mikael Pettersson <mikpe@...uu.se> :
 > > [...]
 > >> May I suggest that 6709fe9a27e43a4931938fe0d7f2cc5edef31386 is reverted
 > >> until this regression is debugged and fixed?
 > > 
 > > Yes.
 > > 
 > Hello guys,
 > I made 3rd attempt to enable the ability to initialize r8169's MAC address
 > on initialization. The proposed patch below works for all my Realtek devices,
 > but you had some issues with the previous one. Could you please test it on your
 > devices? I would like to close finally this long term issue.

Sorry, this one breaks my Thecus n2100 NAS box just like before.
Here's a dmesg diff from 2.6.30 vanilla and 2.6.30 + this patch:

@@ -158,11 +158,13 @@
 r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
 r8169 0000:00:01.0: enabling Mem-Wr-Inval
 r8169 0000:00:01.0: no PCI Express capability
-eth0: RTL8169sb/8110sb at 0xe0810200, 00:14:fd:30:11:78, XID 10000000 IRQ 27
+r8169 0000:00:01.0: MAC address found in EEPROM: 00:14:fd:10:00:00
+eth0: RTL8169sb/8110sb at 0xe0810200, 00:00:00:00:00:00, XID 10000000 IRQ 27
 r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
 r8169 0000:00:02.0: enabling Mem-Wr-Inval
 r8169 0000:00:02.0: no PCI Express capability
-eth1: RTL8169sb/8110sb at 0xe0814300, 00:14:fd:30:11:79, XID 10000000 IRQ 30
+r8169 0000:00:02.0: MAC address found in EEPROM: 00:14:fd:10:00:00
+eth1: RTL8169sb/8110sb at 0xe0814300, 00:00:00:00:00:00, XID 10000000 IRQ 30
 physmap platform flash device: 01000000 at f0000000
 physmap-flash.0: Found 1 x16 devices at 0x0 in 16-bit bank
  Intel/Sharp Extended Query Table at 0x0031
@@ -250,6 +246,4 @@
 EXT3 FS on sda5, internal journal
 EXT3-fs: mounted filesystem with ordered data mode.
 Adding 2008116k swap on /dev/sda3.  Priority:-1 extents:1 across:2008116k 
-r8169: eth0: link up
-r8169: eth0: link up
 warning: `dbus-daemon' uses 32-bit capabilities (legacy support in use)

/Mikael
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html