netdev - Re: [RFC net 02/03]: allow to propagate errors through ->ndo_hard_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 19 Jun 2009 14:23:25 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	netdev@...r.kernel.org
Subject: Re: [RFC net 02/03]: allow to propagate errors through	->ndo_hard_start_xmit()

Jarek Poplawski wrote:
> On 09-06-2009 18:17, Patrick McHardy wrote:
>> commit c2104095c3a1023b4f4809c90092145dff093c88
>> Author: Patrick McHardy <kaber@...sh.net>
>> Date:   Tue Jun 9 17:55:34 2009 +0200
>>
>>     net: allow to propagate errors through ->ndo_hard_start_xmit()
>>     
> ...
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index 11560e3..b2e9953 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -1731,6 +1731,8 @@ gso:
>>  		nskb->next = NULL;
>>  		rc = ops->ndo_start_xmit(nskb, dev);
>>  		if (unlikely(rc)) {
>> +			if (rc & ~NETDEV_TX_MASK)
>> +				return rc;
> 
> This is probably not enough: what about the rest of the skb
> (qdisc_restart() would skip requeuing)?

Good point, I guess we should drop the remaining parts.
I'll fix that up, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html