netdev - Re: [PATCH 1/1] Net: qla3xxx, remove sleeping in atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 20 Jun 2009 01:21:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jirislaby@...il.com
Cc:	linux-driver@...gic.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Net: qla3xxx, remove sleeping in atomic

From: Jiri Slaby <jirislaby@...il.com>
Date: Fri, 19 Jun 2009 17:13:32 +0200

> Hi, we've found this sleep-inside-spinlock.
> 
> The fix below totally untested, please review carefully.
> 
> --
> 
> We cannot sleep in ql_reset_work under spinlock, unlock before sleep,
> relock after.
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>

This looks good.  The spinlock is just required to be held
around the register accesses.  It's going to drop the lock
as soon as the bits settle post-reset anyways and then the
driver goes off and modifies other state outside of the lock.

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html