netdev - Re: [PATCH] Consolidate shared code between enic and fnic drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Jun 2009 16:53:38 -0700
From:	Joe Eykholt <jeykholt@...co.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	Mike Christie <michaelc@...wisc.edu>,
	Scott Feldman <scofeldm@...co.com>,
	Hannes Reinecke <hare@...e.de>,
	James.Bottomley@...senPartnership.com, davem@...emloft.net,
	gospo@...hat.com, abjoglek@...co.com, netdev@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH] Consolidate shared code between enic and fnic drivers.

Roland Dreier wrote:
>  > For the includes then, do we put them in include/shared/cisco_vnic or
>  > do we do that EXTRA_CFLAGS += -Idrivers/shared/cisco_vnic? In that
>  > patch for fnic/vnic/enic I sent a while back I did the EXTRA_CFLAGS,
>  > only because that is how cxgb3/iw_cxgb3 was doing it. I am not sure if
>  > that is nice or not. It was on the TODO to check it out.
> 
> For mlx4, I created include/linux/mlx4/.
> 
> Maybe create include/shared and move to that?

Or how about include/drivers/mlx4 and similarly for cisco_vnic
(but we're leaning towards cvnic)?

include/drivers seems more like a generally useful subdirectory
with some meaning.   include/shared leaves one guessing as to what
it might be.
	
	Joe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html