netdev - Re: [PATCH] skbuff: don't corrupt mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 6 Jul 2009 11:23:14 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	acme@...stprotocols.net, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] skbuff:  don't corrupt mac_header on skb expansion

On Sun, 5 Jul 2009 11:55:21 +0800
Herbert Xu <herbert@...dor.apana.org.au> wrote:

> Stephen Hemminger <shemminger@...tta.com> wrote:
> > The skb mac_header field is sometimes NULL (or ~0u) as a sentinel
> > value. The places where skb is expanded add an offset which would
> > change this flag into an invalid pointer (or offset).
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> What uses skb_mac_header_was_set apart from a debugging printk
> in route.c and nfnetlink_log (which is also essentially a debugging
> printk)?
> 
> This seems to be a bit much just to make a couple printks work?
> 
> What about using mac_len instead to figure out whether the MAC
> header is there?
> 
> Cheers,

No worries, either way works, I was just trying to keep acme's original code

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html