netdev - Re: [PATCH] fec: fix definition of 5272 version of FEC_X_DES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jul 2009 18:27:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerg@...pgear.com
Cc:	netdev@...r.kernel.org, gerg@...inux.org, s.hauer@...gutronix.de
Subject: Re: [PATCH] fec: fix definition of 5272 version of
 FEC_X_DES_ACTIVE register

From: Greg Ungerer <gerg@...pgear.com>
Date: Tue, 7 Jul 2009 11:23:34 +1000

> fec: fix definition of 5272 version of FEC_X_DES_ACTIVE register
> 
> The ColdFire 5272 FEC driver has a different register address map
> than other users of the FEC driver. And its definition of the
> FEC_X_DES_ACTIVE register is incorrect, it should be 0x14.
> The fec interface cannot transmit data with the old value.
> 
> Signed-off-by: Greg Ungerer <gerg@...inux.org>

This wasn't handled well at all.

You sent me what amounted to a cleanup patch to remove the
trailing ";" in these definitions first.  I can only put
that into net-next-2.6

Now you send me a real bug fix for one of these macro
values and it only applies on top of that ";" removal
patch.

That completely sucks.  Now I can't just apply this to
net-2.6 to get the bug fixed.

You should have sent just the bug fix, then waited a week
or so for the net-2.6 tree to get merged into the net-next-2.6
tree and then you could send the ";" cleanup cleanly on top
of that.

I can't apply this so I'm rejecting it in patchwork.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html