netdev - Re: [PATCH] sit: fix regression: do not release skb->dst before xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Jul 2009 15:24:15 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Sascha Hlusiak <contact@...chahlusiak.de>
CC:	netdev@...r.kernel.org, berni@...kenwald.de
Subject: Re: [PATCH] sit: fix regression: do not release skb->dst before xmit

Sascha Hlusiak a écrit :
> The sit module makes use of skb->dst in it's xmit function,
> so since 93f154b594fe47 sit tunnels are broken, because the
> flag IFF_XMIT_DST_RELEASE is not unset.
> 
> This patch unsets that flag for sit devices to fix this
> regression.
> 
> Signed-off-by: Sascha Hlusiak <contact@...chahlusiak.de>

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

> ---
>  net/ipv6/sit.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
> index 68e5230..98b7327 100644
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -1018,6 +1018,7 @@ static void ipip6_tunnel_setup(struct net_device *dev)
>  	dev->hard_header_len 	= LL_MAX_HEADER + sizeof(struct iphdr);
>  	dev->mtu		= ETH_DATA_LEN - sizeof(struct iphdr);
>  	dev->flags		= IFF_NOARP;
> +	dev->priv_flags	       &= ~IFF_XMIT_DST_RELEASE;
>  	dev->iflink		= 0;
>  	dev->addr_len		= 4;
>  	dev->features		|= NETIF_F_NETNS_LOCAL;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html