netdev - Re: [ofa-general][PATCH] mlx4_core: Synch catastrophic flow with module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Jul 2009 12:45:32 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	David Miller <davem@...emloft.net>
Cc:	yevgenyp@...lanox.co.il, general@...ts.openfabrics.org,
	netdev@...r.kernel.org
Subject: Re: [ofa-general][PATCH] mlx4_core: Synch catastrophic flow with module unload

 > Applied, thanks.

Dave, please don't apply mlx4_core patches without giving me a chance to
review them.  In this case the patch looks buggy to me: I don't see how
it handles, say, hot remove of one device -- it only handles module
removal.  And I would hope we could fix this without adding a global
symbol as namespace polluting as "drv_mutex".

Yevgeny didn't even send this patch to you; he just cc'ed netdev as a
courtesy.  However I understand that the physical location of mlx4_core
in drivers/net makes it easy to do this.  Maybe this is the best
argument in favor of moving the mlx4_core stuff to drivers/shared?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html