netdev - Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2009 09:35:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	aj@...n.ch
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, kaber@...sh.net
Subject: Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header

From: Andreas Jaggi <aj@...n.ch>
Date: Tue, 14 Jul 2009 09:14:10 +0200

> On Mon, Jul 13, 2009 at 10:44:33AM -0700, David Miller wrote:
>> Why not just create a new IFLA_GRE_* attribute to pass in
>> flags like this that purely are private to the GRE Linux
>> tunnel driver and have nothing to do with values defined
>> by GRE tunnel headers at all?
> 
> OK. What would be an appropriate place to store such a private flag in
> the GRE driver?
> 
> I thought of extending the ip_tunnel_parms struct with '__u16 priv_flags'
> (But this would break compatibility with the iproute2 tools?)

You'll need to find a place.  Worst case you can make a top-level
new structure, that contains the user interface structure and
then the new __u16 priv_flags thing.  And allocate that per-tunnel
instead of what it does now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html