lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 Jul 2009 22:04:48 +0400 From: Anton Vorontsov <avorontsov@...mvista.com> To: Grant Likely <grant.likely@...retlab.ca> Cc: davem@...emloft.net, afleming@...escale.com, netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, leoli@...escale.com Subject: Re: [PATCH v2 0/4] net: Revive fixed link support On Fri, Jul 17, 2009 at 01:31:25AM -0600, Grant Likely wrote: [...] > Part of the problem I think is that the phylib code merges two separate > constructs; the construct of an MDIO bus (on which many device may > reside, not all of them PHYs), and the construct of an MII link whose > speed and configuration need to be manipulated. I've run into problems > myself on how best to handle things like Ethernet switches which > definitely do not behave like PHYs and the phylib state machine cannot > be used on them. It seems to me that the whole 'dummy phy' approach > is just an artifact of the phylib model not being quite right yet. Yep. With a bit of phylib rework we can remove all the MDIO emulation stuff from phy/fixed.c driver, and leave there just speed/duplex/pause assignments. Though, I still believe that we should avoid two code paths in the drivers. One of the code paths will be constantly broken if we do so. > I > want to investigate the possibility of separating the two concepts, but > that will require a fair bit of thought and experimentation. That would be great indeed. [...] > Anton, once again I don't have hardware to test this, so I rely on you > to tell be if I screwed it up. It has been compile tested. Works fine here, thanks! -- Anton Vorontsov email: cbouatmailru@...il.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists