netdev - Re: [PATCH] register at91_ether using platform_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 Jul 2009 11:24:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	avictor.za@...il.com
Cc:	u.kleine-koenig@...gutronix.de, linux-kernel@...r.kernel.org,
	dbrownell@...rs.sourceforge.net, netdev@...r.kernel.org,
	paulius.zaleckas@...tonika.lt, marc.pignat@...s.ch,
	linux@...im.org.za, 12o3l@...cali.nl, akpm@...ux-foundation.org,
	gregkh@...e.de
Subject: Re: [PATCH] register at91_ether using platform_driver_probe

From: Andrew Victor <avictor.za@...il.com>
Date: Wed, 22 Jul 2009 19:46:24 +0200

> hi,
> 
>> at91ether_probe lives in .init.text, so using platform_driver_register
>> to register it is wrong because binding a device after the init memory
>> is discarded (e.g. via sysfs) results in an oops.
>>
>> As requested by David Brownell platform_driver_probe is used instead of
>> moving the probe function to .devinit.text as proposed initially.
>> This saves some memory, but devices registered after the driver is
>> probed are not bound (probably there are none) and binding via sysfs
>> isn't possible.
> 
> 
> Acked-by: Andrew Victor <linux@...im.org.za>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html