| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jul 2009 10:01:24 -0700 (PDT) From: David Miller <davem@...emloft.net> To: kaber@...sh.net Cc: sarveshwarb@...verengines.com, netdev@...r.kernel.org Subject: Re: [PATCH] be2net: Adding support for 802.1ad (q-in-q mode) From: Patrick McHardy <kaber@...sh.net> Date: Thu, 23 Jul 2009 18:33:05 +0200 > David Miller wrote: >>> Sarveshwar Bandi wrote: >>>> The outer vlan is totally transparent to the host. It is used by the NIC >>>> to demux packets across multiple pci network functions. Currently the >>>> outer vlan tags are configured on the NIC by OEM provided utilities. >>> I see. A proper changelog entry would have explained that and avoided >>> all this confusion. Not that I think using another tool for this is a >>> good solution, but no objections from a functional POV. >> >> Using OEM tools makes no sense, there should be something like an >> ethtool interface for changing this setting and appropriate changes >> to the common userland tools to provide access to them. >> >> I'm not putting this change in until there is common infrastructure >> submitted to common tools to control this configuration. > > Thanks, thats my opinion as well. But I think we should handle > Q-in-Q using the VLAN netlink API and iproute instead of ethtool > for consistency. That works for me too. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists