netdev - Re: [net-2.6 PATCH] ixgbe: fix for 82599 errata marking UDP checksum errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 26 Jul 2009 23:11:40 -0700 (Pacific Daylight Time)
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	David Miller <davem@...emloft.net>
cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"Skidmore, Donald C" <donald.c.skidmore@...el.com>
Subject: Re: [net-2.6 PATCH] ixgbe: fix for 82599 errata marking UDP checksum
 errors

On Sun, 26 Jul 2009, David Miller wrote:

> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Thu, 23 Jul 2009 21:00:39 -0700
> 
> > From: Don Skidmore <donald.c.skidmore@...el.com>
> > 
> > There is an 82599 errata that UDP frames with a zero checksum are
> > incorrectly marked as checksum invalid by the hardware.  This was
> > leading to misleading hw_csum_rx_error counts. This patch adds a
> > test around this counter increase for this condition.
> > 
> > Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Applied, thanks.
> 
> But I wonder.   When you compute a checksum, and it's zero,
> you have to use the complement as the checksum value.  How
> does that relate to the problem being tackled here?

The problem is our hardware has an errata.  If the packet data contains no 
checksum, or no checksum computed, our hardware doesn't recognize it.  So 
when it tries to compute the checksum on Rx, it doesn't just figure out 
that it needs to use the one's complement.  So it's not recognizing the 
fact the checksum is either not computed, or computes to zero.

The only place we've seen this show up is receiving from pktgen, where no 
checksum is computed.  It is a really stupid HW errata, and is just an 
annoyance really (our bad checksum counter soars when doing pktgen stress 
testing).

Cheers,
-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html