netdev - Re: [PATCH 6/7] net: Add vbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Aug 2009 16:24:10 -0400
From:	Gregory Haskins <gregory.haskins@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	Gregory Haskins <ghaskins@...ell.com>,
	linux-kernel@...r.kernel.org,
	alacrityvm-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH 6/7] net: Add vbus_enet driver

Stephen Hemminger wrote:
> On Mon, 03 Aug 2009 16:10:37 -0400
> Gregory Haskins <ghaskins@...ell.com> wrote:
> 
>> Stephen Hemminger wrote:
>>> On Mon, 03 Aug 2009 13:18:02 -0400
>>> Gregory Haskins <ghaskins@...ell.com> wrote:
>>>
>>>> +
>>>> +static const struct net_device_ops vbus_enet_netdev_ops = {
>>>> +	.ndo_open          = vbus_enet_open,
>>>> +	.ndo_stop          = vbus_enet_stop,
>>>> +	.ndo_set_config    = vbus_enet_config,
>>>> +	.ndo_start_xmit    = vbus_enet_tx_start,
>>>> +	.ndo_change_mtu	   = vbus_enet_change_mtu,
>>>> +	.ndo_tx_timeout    = vbus_enet_timeout,
>>>> +};
>>>
>>> Missing 
>>> 	.ndo_set_mac_address = eth_mac_addr,
>>> 	.ndo_validate_addr   = eth_validate_addr,
>>>
>> Ack.
>>
>>> Also, should have change_mtu.
>> note that I do have .ndo_change_mtu.  I assume this is what you are
>> referring to and just missed it.  If there is something else I need
>> there, let me know.
> 
> If you don't have a change_mtu, then MTU is unlimited.

Is "change_mtu" different from .ndo_change_mtu" on the ndo struct?
That's whats confusing me, as I have the .ndo one already.  Is there
something else I need in addition, or should I be ok as is?

> Can the device handle 64K or larger transfers?

Well, its been tested with 64K GSO packets at least.  I think it could
handle arbitrarily large packets as long as they are paged, but I have
never tried this beyond 64k due to the simple L4 limitations of 64k.

Thanks Stephen,
-Greg


Download attachment "signature.asc" of type "application/pgp-signature" (268 bytes)