Avoid any possible problems with accessing PHY registers on shutdown. This is a purely theoretical issue and is not related to any of the outstanding bug reports. Since receiver and transmitter are already shutdown and phy interrupts for this device are already disabled, there should already be enough protection. Suggested-by: Mike McCormack Signed-off-by: Stephen Hemminger --- a/drivers/net/sky2.c 2009-08-06 08:40:56.097359280 -0700 +++ b/drivers/net/sky2.c 2009-08-06 08:41:38.949377326 -0700 @@ -1883,7 +1883,9 @@ static int sky2_down(struct net_device * synchronize_irq(hw->pdev->irq); napi_synchronize(&hw->napi); + spin_lock_bh(&sky2->phy_lock); sky2_phy_power_down(hw, port); + spin_unlock_bh(&sky2->phy_lock); /* turn off LED's */ sky2_write16(hw, B0_Y2LED, LED_STAT_OFF); -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html