lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Aug 2009 08:29:43 -0700 From: Stephen Hemminger <shemminger@...ux-foundation.org> To: Mike McCormack <mikem@...g3k.org> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] sky2: Create buffer alloc and free helpers On Sun, 09 Aug 2009 20:40:16 +0900 Mike McCormack <mikem@...g3k.org> wrote: > Refactor similar two sections of code that free buffers into one. > As a side effect, only call tx_init() in sky2_up() if all buffer > allocations succeed. > > Signed-off-by: Mike McCormack <mikem@...g3k.org> > + if (0 > sky2_alloc_buffers(sky2)) > goto err_out; Don't change code style. Especially in mid driver. Just return 0 for success and errno or -1. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists