netdev - net/unix : possible race bug at unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2009 00:00:22 +0900
From:	홍신 shin hong <hongshin@...il.com>
To:	netdev@...r.kernel.org
Subject: net/unix : possible race bug at unix_create1()

Hi. I am reporting a possible race bug at unix_create1()
in net/unix/af_unix.c of Linux 2.6.30.4.

Concurrent executions of unix_create1() function
in two different threads may result race condition
when unix_nr_socks +1 == 2 * get_max_files().

It is possible that no thread can pass the if-condition
checking if two atomic_inc() operations are executed
before.

It seems that it would be better to combine two
atomic operations into one atomic_inc_and_return().

Please examine the code and let me know your opinion.

Thank you

Sincerely
Shin Hong
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html