netdev - Re: [PATCH 1/1] NET: llc, zero sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 Aug 2009 18:56:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jirislaby@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	acme@...stprotocols.net
Subject: Re: [PATCH 1/1] NET: llc, zero sockaddr_llc struct

From: Jiri Slaby <jirislaby@...il.com>
Date: Sat, 22 Aug 2009 20:58:55 +0200

> sllc_arphrd member of sockaddr_llc might not be set. Zero sllc
> before copying it to the above layers.
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>

I know it seems arbitrary, but could you please memset() on the
structure instead of using an empty initializer so that it's
consistent with how all other ->getname() implementations deal with
this issue?

It's easier to audit that way.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html