netdev - [PATCH] netfilter: bridge: refcount fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Aug 2009 19:18:31 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"David S. Miller" <davem@...emloft.net>
CC:	Linux Netdev List <netdev@...r.kernel.org>,
	Patrick McHardy <kaber@...sh.net>,
	Bart De Schuymer <bdschuym@...dora.be>
Subject: [PATCH] netfilter: bridge: refcount fix

Hi David

I found following by code review only, I am not sure it is critical enough for net-2.6

This is a stable candidate, bug is more than 2 years old.

Thanks

commit f216f082b2b37c4943f1e7c393e2786648d48f6f
([NETFILTER]: bridge netfilter: deal with martians correctly)
added a refcount leak on in_dev.

Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
---
diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
index 4fde742..c62eca3 100644
--- a/net/bridge/br_netfilter.c
+++ b/net/bridge/br_netfilter.c
@@ -386,6 +386,7 @@ static int br_nf_pre_routing_finish(struct sk_buff *skb)
 				dst_release((struct dst_entry *)rt);
 			}
 free_skb:
+			in_dev_put(in_dev);
 			kfree_skb(skb);
 			return 0;
 		} else {

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html