netdev - Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2009 09:25:03 +0200
From:	Holger Schurig <hs4233@...l.mn-solutions.de>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Tomas Winkler <tomasw@...il.com>,
	"Luis R. Rodriguez" <mcgrof@...il.com>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH 1/1] iwmc3200: add more SDIO device ids

On Tuesday 25 August 2009 01:21:58 Marcel Holtmann wrote:
> My personal vote is for keeping all IDs inside the drivers.
> And I also prefer to keep the plain hex values and just put a
> comment above them which device this is. Something like this:
>
> static struct usb_device_id btusb_table[] = {
> 	/* Generic Bluetooth USB device */
> 	{ USB_DEVICE_INFO(0xe0, 0x01, 0x01) },

+1

When I have an unknown device (and not compiled all modules) it's 
so much easier to do an

grep -ri 057c drivers/usb

then to do the same on include/ and then again to find the driver 
that uses this id. For the same reason, I prefer 0x057c in the 
source and not 0x57c.

-- 
http://www.holgerschurig.de
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html