netdev - Re: [PATCH] 8 bytes kernel memory disclosure in AppleTalk getsockname.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2009 14:39:31 +0200
From:	Clement LECIGNE <clement.lecigne@...asq.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] 8 bytes kernel memory disclosure in AppleTalk
	getsockname.

Wed, Aug 26, 2009 at 02:35:57PM +0200, Eric Dumazet wrote:
> Clement LECIGNE a écrit :
> > Hi,
> > 
> > In function atalk_getname(), sockaddr_at is returned in userland without
> > zero'ing the "char sat_zero[8]" field. This bug allows user to display 8
> > bytes leaked from the kernel stack.
> > 
> > Here is a patch that zero the whole sockaddr_at structure before
> > processing it. It should fix this bug.
> > 
> > Signed-off-by: Clément Lecigne <clement.lecigne@...asq.com>
> > --- linux/net/appletalk/ddp.c	2009-08-26 11:35:59.000000000 +0200
> > +++ linux/net/appletalk/ddp.c	2009-08-26 11:36:30.000000000 +0200
> > @@ -1241,6 +1241,8 @@ static int atalk_getname(struct socket *
> >  		if (atalk_autobind(sk) < 0)
> >  			return -ENOBUFS;
> >  
> > +	memset(&sat, 0, sizeof(struct sockaddr_at));
> > +
> >  	*uaddr_len = sizeof(struct sockaddr_at);
> >  
> >  	if (peer) {
> > 
> Hi Clement
> 
> Well, I submitted same patch some weeks ago and I just checked that
> it was already in Linus tree.
> 
> author	Eric Dumazet <eric.dumazet@...il.com>
> 	Thu, 6 Aug 2009 02:27:43 +0000 (02:27 +0000)
> committer	David S. Miller <davem@...emloft.net>
> 	Thu, 6 Aug 2009 20:08:45 +0000 (13:08 -0700)
> commit	3d392475c873c10c10d6d96b94d092a34ebd4791
> 
> appletalk: fix atalk_getname() leak
> 
> atalk_getname() can leak 8 bytes of kernel memory to user
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> 
> Dont worry, it'll be included in upcoming 2.6.31 kernel,
> and backported to previous ones as well.

Hi Eric,

Oups, shame on me, I have not checked Linus tree before submitting the
patch.

Sorry,

-- 
Clément LECIGNE,
-Only one remote hole in the default install, in more than 10 years!<br>
+Only two remote holes in the default install, in more than 10 years!<br>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html