netdev - skb header allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2009 22:04:10 -0500
From:	Chris Ross <chris@...pilednetworks.com>
To:	netdev@...r.kernel.org
Subject: skb header allocation

I have a network driver that acts as a Ethernet device and builds up a
series of outer headers on skb(s) it receives from upper layers. I am
currently using the technique that is in ipip.c to ensure I have
enough room to add my header ...

if (skb_headroom(skb) < some_value || skb_shared(skb) ||
         ((skb_cloned(skb) && !skb_clone_writable(skb, 0))))
   {
      if ((skb2 = skb_realloc_headroom(skb, some_value)) == NULL)
         return -1;

      dev_kfree_skb(skb);
      skb = skb2;
   }

Is this the best practice for a high bandwidth scenario?

thanks

-chris
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html