lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 02 Sep 2009 22:43:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jgarzik@...ox.com
Cc:	ajitk@...verengines.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net/ethtool: Add support for the ethtool
 feature to flash firmware image from a specified file.

From: Jeff Garzik <jgarzik@...ox.com>
Date: Thu, 03 Sep 2009 01:33:01 -0400

> It passes a _filepath_ directly into the kernel?  That seems quite
> wrong...
> 
> we fixed kernel drivers to _not_ think they could read directly from
> the userland filesystem many years ago.
> 
> Seems like passing in an mmap'd fd would be far preferable.

Jeff, it's passing in something that's going to requested via
the firmware loading infrastructure in the kernel.

It is the most appropriate way to do this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ