lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 03 Sep 2009 20:27:45 +0200 From: Patrick McHardy <kaber@...sh.net> To: Eric Dumazet <eric.dumazet@...il.com> CC: "David S. Miller" <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: [PATCH net-next-2.6] macvlan: add multiqueue capability Eric Dumazet wrote: > Patrick McHardy a écrit : >> The patch looks fine, but it just occured to me that this won't >> have any effect since both VLAN and macvlan use a tx_queue_len of 0, >> so they will by default have queueing disabled. In fact this >> will increase costs for the default case since we're now hashing >> every packet. > > Just read again dev_queue_xmit(), in case we have no queueing > on macvlan/vlan > > Having mutiple txq should help multi flow / multi cpus setups, > since hashing will provide more chances to hit different txq/locks, > and let several cpus run concurrently, each one on a different queue. You're right, I missed that we're also perfoming locking in the noqueue case. Sorry :) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists