netdev - Re: [PATCH] netlink: silence compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Sep 2009 20:32:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	marcel@...tmann.org
Cc:	brian.haley@...com, netdev@...r.kernel.org
Subject: Re: [PATCH] netlink: silence compiler warning

From: Marcel Holtmann <marcel@...tmann.org>
Date: Sat, 05 Sep 2009 03:08:01 +0200

> can we please add the err = -E... where it actually is needed and not
> stupidly go ahead and silence compiler warnings with err = 0. This has
> been posted before.

Ummm, no.  Actually Brian's patch is correct.

I can't even prove that there are no paths where err won't
be initialized properly to something.

And if such an occurance happens, returning "0" is absolutely
the right thing to do.

And that's what Brian's patch does.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html