netdev - Re: net_sched: fix estimator lock selection for mq child qdiscs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2009 18:11:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	netdev@...r.kernel.org
Subject: Re: net_sched: fix estimator lock selection for mq child qdiscs

From: Patrick McHardy <kaber@...sh.net>
Date: Wed, 09 Sep 2009 17:59:01 +0200

>     net_sched: fix estimator lock selection for mq child qdiscs
>     
>     When new child qdiscs are attached to the mq qdisc, they are actually
>     attached as root qdiscs to the device queues. The lock selection for
>     new estimators incorrectly picks the root lock of the existing and
>     to be replaced qdisc, which results in a use-after-free once the old
>     qdisc has been destroyed.
>     
>     Mark mq qdisc instances with a new flag and treat qdiscs attached to
>     mq as children similar to regular root qdiscs.
>     
>     Additionally prevent estimators from being attached to the mq qdisc
>     itself since it only updates its byte and packet counters during dumps.
>     
>     Signed-off-by: Patrick McHardy <kaber@...sh.net>

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html