lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Sep 2009 15:41:25 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mcarlson@...adcom.com Cc: benli@...adcom.com, netdev@...r.kernel.org Subject: Re: 5717 support commit is buggy From: David Miller <davem@...emloft.net> Date: Fri, 11 Sep 2009 15:15:54 -0700 (PDT) > I'm about to do some tests, but I suspect it's this change: > > @@ -111,7 +111,8 @@ > * replace things like '% foo' with '& (foo - 1)'. > */ > #define TG3_RX_RCB_RING_SIZE(tp) \ > - ((tp->tg3_flags2 & TG3_FLG2_5705_PLUS) ? 512 : 1024) > + (((tp->tg3_flags & TG3_FLAG_JUMBO_CAPABLE) && \ > + !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS)) ? 512 : 1024) > > #define TG3_TX_RING_SIZE 512 > #define TG3_DEF_TX_RING_PENDING (TG3_TX_RING_SIZE - 1) > > and thus an incorrect RCB ring size is being used which eventually > locks up the card. Confirmed, reverting that part of the change makes my card work again. Broadcom folks, that is the correct test? This needs to be fixed urgently. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists